Re: [PATCH] drm/amdgpu/display: Fix compilation issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 7, 2022 at 4:27 AM Chandan Vurdigere Nataraj
<chandan.vurdigerenataraj@xxxxxxx> wrote:
>
> [Why]
> Getting below build errors:
> drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1419:3: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
>                 default:
>                 ^
> drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1535:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
>         default:
>         ^
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:3276:20: error: variable 'v1_5' is uninitialized when used here [-Werror,-Wuninitialized]
>                         for (i = 0; i < v1_5->number_of_path; ++i)
>                                         ^~~~
>
> [How]
> Fix compilation issues
>
> Signed-off-by: Chandan Vurdigere Nataraj <chandan.vurdigerenataraj@xxxxxxx>

Acked-by: Alex Deucher <alexander.deucher@xxxxxxx>

>
> diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
> index 3540b46765fb..25791ed0559d 100644
> --- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
> +++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
> @@ -1415,7 +1415,7 @@ static enum bp_result bios_parser_get_lttpr_caps(
>                 case 5:
>                         result = get_disp_caps_v4_5(bp, dce_caps);
>                         *dce_caps = !!(*dce_caps & DCE_INFO_CAPS_LTTPR_SUPPORT_ENABLE);
> -
> +                       break;
>                 default:
>                         break;
>                 }
> @@ -1532,6 +1532,7 @@ static enum bp_result bios_parser_get_embedded_panel_info(
>                 default:
>                         break;
>                 }
> +               break;
>         default:
>                 break;
>         }
> @@ -3251,7 +3252,7 @@ static enum bp_result get_bracket_layout_record(
>         static enum bp_result result;
>         struct object_info_table *tbl;
>         struct display_object_info_table_v1_4 *v1_4;
> -    struct display_object_info_table_v1_5 *v1_5;
> +       struct display_object_info_table_v1_5 *v1_5;
>
>         if (slot_layout_info == NULL) {
>                 DC_LOG_DETECTION_EDID_PARSER("Invalid slot_layout_info\n");
> @@ -3259,6 +3260,7 @@ static enum bp_result get_bracket_layout_record(
>         }
>         tbl = &bp->object_info_tbl;
>         v1_4 = tbl->v1_4;
> +       v1_5 = tbl->v1_5;
>
>         result = BP_RESULT_NORECORD;
>         switch (bp->object_info_tbl.revision.minor) {
> --
> 2.25.1
>



[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux