On 2022-06-06 12:00, Alex Deucher wrote: > On Mon, Jun 6, 2022 at 11:54 AM Harry Wentland <harry.wentland@xxxxxxx> wrote: >> >> On 2022-06-06 11:42, Alex Deucher wrote: >>> Add proper handling for PPC64. >>> >>> Reported-by: kernel test robot <lkp@xxxxxxxxx> >>> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx> >>> --- >>> drivers/gpu/drm/amd/display/dc/dcn32/Makefile | 9 ++++++++- >>> drivers/gpu/drm/amd/display/dc/dcn321/Makefile | 9 ++++++++- >>> 2 files changed, 16 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/Makefile b/drivers/gpu/drm/amd/display/dc/dcn32/Makefile >>> index 6e0328060255..3d09db3070f4 100644 >>> --- a/drivers/gpu/drm/amd/display/dc/dcn32/Makefile >>> +++ b/drivers/gpu/drm/amd/display/dc/dcn32/Makefile >>> @@ -15,12 +15,19 @@ DCN32 = dcn32_resource.o dcn32_hubbub.o dcn32_hwseq.o dcn32_init.o \ >>> dcn32_dio_stream_encoder.o dcn32_dio_link_encoder.o dcn32_hpo_dp_link_encoder.o \ >>> dcn32_mpc.o >>> >>> -CFLAGS_$(AMDDALPATH)/dc/dcn32/dcn32_resource.o := -mhard-float -msse >>> +ifdef CONFIG_X86 >>> +CFLAGS_$(AMDDALPATH)/dc/dcn32/dcn32_resource.o := -msse >> >> Should this have an -mhard-float as well? I see that in the other >> Makefiles. >> >> The entry below only adds it for gcc, not for clang. > > A bunch of the other resource Makefiles don't seem to have it. E.g., > drivers/gpu/drm/amd/display/dc/dcn30/Makefile > drivers/gpu/drm/amd/display/dc/dcn302/Makefile > True, and things worked so far. In that case we probably don't need it. Reviewed-by: Harry Wentland <harry.wentland@xxxxxxx> Harry > drivers/gpu/drm/amd/display/dc/dcn201/Makefile and > drivers/gpu/drm/amd/display/dc/dml/Makefile do include it however. > > Alex > >> >> Harry >> >>> +endif >>> + >>> +ifdef CONFIG_PPC64 >>> +CFLAGS_$(AMDDALPATH)/dc/dcn32/dcn32_resource.o := -mhard-float -maltivec >>> +endif >>> >>> ifdef CONFIG_CC_IS_GCC >>> ifeq ($(call cc-ifversion, -lt, 0701, y), y) >>> IS_OLD_GCC = 1 >>> endif >>> +CFLAGS_$(AMDDALPATH)/dc/dcn32/dcn32_resource.o += -mhard-float >>> endif >>> >>> ifdef IS_OLD_GCC >>> diff --git a/drivers/gpu/drm/amd/display/dc/dcn321/Makefile b/drivers/gpu/drm/amd/display/dc/dcn321/Makefile >>> index 9b61d08700ca..5896ca303e39 100644 >>> --- a/drivers/gpu/drm/amd/display/dc/dcn321/Makefile >>> +++ b/drivers/gpu/drm/amd/display/dc/dcn321/Makefile >>> @@ -12,12 +12,19 @@ >>> >>> DCN321 = dcn321_resource.o dcn321_dio_link_encoder.o >>> >>> -CFLAGS_$(AMDDALPATH)/dc/dcn321/dcn321_resource.o := -mhard-float -msse >>> +ifdef CONFIG_X86 >>> +CFLAGS_$(AMDDALPATH)/dc/dcn321/dcn321_resource.o := -msse >>> +endif >>> + >>> +ifdef CONFIG_PPC64 >>> +CFLAGS_$(AMDDALPATH)/dc/dcn321/dcn321_resource.o := -mhard-float -maltivec >>> +endif >>> >>> ifdef CONFIG_CC_IS_GCC >>> ifeq ($(call cc-ifversion, -lt, 0701, y), y) >>> IS_OLD_GCC = 1 >>> endif >>> +CFLAGS_$(AMDDALPATH)/dc/dcn321/dcn321_resource.o += -mhard-float >>> endif >>> >>> ifdef IS_OLD_GCC >>
