On Thu, Jun 2, 2022 at 11:33 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > On Thu, Jun 02, 2022 at 10:24:58AM -0400, Alex Deucher wrote: > > On Thu, Jun 2, 2022 at 7:51 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > > > > > On Thu, Jun 02, 2022 at 08:26:03AM +0200, Ernst Sjöstrand wrote: > > > > Dan: I also ran Smatch which resulted in the following discussion: > > > > > > > > https://lists.freedesktop.org/archives/amd-gfx/2022-May/079228.html > > > > > > Since the bounds check is dead code which does not make sense and is not > > > required, another idea would be to just delete it. > > > > It wouldn't be dead code if AMDGPU_MAX_VCN_INSTANCES ever increased. > > Or we could add a comment to the code I suppose. > > /* Impossible in 2022 but this check might sense in the future */ Good idea. I'll send out a patch. Thanks, Alex > > regards, > dan carpenter >
