Reviewed-by: Guchun Chen <guchun.chen@xxxxxxx>
Regards,
Guchun
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Alex Deucher
Sent: Wednesday, June 1, 2022 5:14 AM
To: Deucher, Alexander <Alexander.Deucher@xxxxxxx>
Cc: amd-gfx list <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] drm/amdgpu: convert nbio_v2_3_clear_doorbell_interrupt() to IP version
Ping?
On Tue, May 24, 2022 at 10:09 PM Alex Deucher <alexander.deucher@xxxxxxx> wrote:
>
> Check IP version rather than asic type.
>
> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c
> b/drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c
> index 6cd1fb2eb913..34c610b9157d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c
> +++ b/drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c
> @@ -547,7 +547,7 @@ static void
> nbio_v2_3_clear_doorbell_interrupt(struct amdgpu_device *adev) {
> uint32_t reg, reg_data;
>
> - if (adev->asic_type != CHIP_SIENNA_CICHLID)
> + if (adev->ip_versions[NBIO_HWIP][0] != IP_VERSION(3, 3, 0))
> return;
>
> reg = RREG32_SOC15(NBIO, 0, mmBIF_RB_CNTL);
> --
> 2.35.3
>
