答复: [PATCH] drm/amdgpu: use proper index in smu_v13_0_7_get_power_profile_mode()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[AMD Official Use Only - General]


Reviewed-by: Kenneth Feng <kenneth.feng@xxxxxxx>

 

Best wishes

Kenneth Feng 

 

 

发件人: Deucher, Alexander <Alexander.Deucher@xxxxxxx>
日期: 星期五, 202256 22:07
收件人: amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>
抄送: Deucher, Alexander <Alexander.Deucher@xxxxxxx>, Feng, Kenneth <Kenneth.Feng@xxxxxxx>, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
主题: [PATCH] drm/amdgpu: use proper index in smu_v13_0_7_get_power_profile_mode()

Otherwise we get an out of bounds access.

Fixes: 878205b8c170 ("drm/amd/pm: enable workload type change on smu_v13_0_7")
Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
Cc: Kenneth Feng <kenneth.feng@xxxxxxx>
Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
---
 drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
index 8e576054bee5..cf5800822174 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
@@ -1361,7 +1361,7 @@ static int smu_v13_0_7_get_power_profile_mode(struct smu_context *smu, char *buf
 do {                                                                                                    \
         size += sysfs_emit_at(buf, size, "%-30s", #field);                                              \
         for (j = 0; j <= PP_SMC_POWER_PROFILE_WINDOW3D; j++)                                            \
-               size += sysfs_emit_at(buf, size, "%-16d", activity_monitor_external[i].DpmActivityMonitorCoeffInt.field);               \
+               size += sysfs_emit_at(buf, size, "%-16d", activity_monitor_external[j].DpmActivityMonitorCoeffInt.field);               \
         size += sysfs_emit_at(buf, size, "\n");                                                         \
 } while (0)
 
--
2.35.1


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux