[AMD Official Use Only] Please add some more info in the description to explain why we need to add TA in SRIOV guest . Regard Shaoyun.liu -----Original Message----- From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of David Yu Sent: Friday, April 22, 2022 10:58 AM To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx Cc: Yu, David <David.Yu@xxxxxxx> Subject: [PATCH] drm/amdgpu: Ta fw needs to be loaded for SRIOV aldebaran Load ta fw during psp_init_sriov_microcode to enable XGMI Signed-off-by: David Yu <David.Yu@xxxxxxx> --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c index f6527aa19238..895251f42853 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c @@ -275,7 +275,8 @@ static int psp_init_sriov_microcode(struct psp_context *psp) ret = psp_init_cap_microcode(psp, "sienna_cichlid"); break; case IP_VERSION(13, 0, 2): - ret = psp_init_cap_microcode(psp, "aldebaran"); + ret = psp_init_ta_microcode(psp, "aldebaran"); + ret &= psp_init_cap_microcode(psp, "aldebaran"); break; default: BUG(); -- 2.25.1