Re: [PATCH] Revert "drm/amdkfd: only allow heavy-weight TLB flush on some ASICs for SVM too"

[philip yang <yangp@xxxxxxx>]

On 2022-04-19 22:32, Lang Yu wrote:

> This reverts commit a129dbca92edaeb5a515a0e5b63ada71cf9b981a.
>
> It causes SVM regressions on Vega10 with XNACK-ON. Just revert it
> at the moment.
>
> ./kfdtest --gtest_filter=KFDSVMRangeTest.MigratePolicyTest
>     
    Reviewed-by: Philip Yang <Philip.Yang@xxxxxxx>
> Signed-off-by: Lang Yu <Lang.Yu@xxxxxxx>
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> index 5afe216cf099..459fa07a3bcc 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> @@ -1229,9 +1229,7 @@ svm_range_unmap_from_gpus(struct svm_range *prange, unsigned long start,
>  			if (r)
>  				break;
>  		}
> -
> -		if (kfd_flush_tlb_after_unmap(pdd->dev))
> -			kfd_flush_tlb(pdd, TLB_FLUSH_HEAVYWEIGHT);
> +		kfd_flush_tlb(pdd, TLB_FLUSH_HEAVYWEIGHT);
>  	}
>  
>  	return r;
>