Re: [PATCH] Revert "drm/amd/display: Pass HostVM enable flag into DCN3.1 DML"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Rodrigo,


Thank you for the patch.


Am 12.04.22 um 20:44 schrieb Rodrigo Siqueira:
This reverts commit 367b3e934f578f6c0d5d8ca5987dc6ac4cd6831d.

While we were testing DCN3.1 with a hub, we noticed that only one of 2
connected displays lights up when using some specific display
resolution. After bisecting this issue, we figured out the commit
mentioned above introduced this issue. We are investigating why this
patch introduced this regression, but we need to revert it for now.

Thank you for bisecting this. It’d be great if you added the information about the test setup: graphics card, displays (model and connected how), model of the hub, and the resolution causing issues.


Kind regards,

Paul


Cc: Harry Wentland <harry.wentland@xxxxxxx>
Cc: Mark Broadworth <Mark.Broadworth@xxxxxxx>
Cc: Michael Strauss <michael.strauss@xxxxxxx>
Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@xxxxxxx>
---
  drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
index 6cc580be7c79..5b3f0c2dfb55 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
@@ -1668,7 +1668,6 @@ int dcn31_populate_dml_pipes_from_context(
  		pipes[pipe_cnt].pipe.src.immediate_flip = true;
pipes[pipe_cnt].pipe.src.unbounded_req_mode = false;
-		pipes[pipe_cnt].pipe.src.hostvm = dc->res_pool->hubbub->riommu_active;
  		pipes[pipe_cnt].pipe.src.gpuvm = true;
  		pipes[pipe_cnt].pipe.src.dcc_fraction_of_zs_req_luma = 0;
  		pipes[pipe_cnt].pipe.src.dcc_fraction_of_zs_req_chroma = 0;



[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux