Dear Alex,
Am 19.03.22 um 08:43 schrieb Paul Menzel:
Dear Alex, dear Chiawen,
Thank you for your patch.
Am 18.03.22 um 22:47 schrieb Alex Hung:
From: Chiawen Huang <chiawen.huang@xxxxxxx>
[Why]
disable/enable leads fec mismatch between hw/sw fec state.
1. Disable/enable of what?
2. How can this be reproduced?
3. s/fec/FEC/
[How]
check fec status to fastboot on/off.
What do you mean by “to fastboot on/off”?
Reviewed-by: Anthony Koo <Anthony.Koo@xxxxxxx>
Acked-by: Alex Hung <alex.hung@xxxxxxx>
Signed-off-by: Chiawen Huang <chiawen.huang@xxxxxxx>
---
drivers/gpu/drm/amd/display/dc/core/dc.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c
b/drivers/gpu/drm/amd/display/dc/core/dc.c
index f6e19efea756..75f9c97bebb0 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
@@ -1496,6 +1496,10 @@ bool dc_validate_boot_timing(const struct dc *dc,
if (!link->link_enc->funcs->is_dig_enabled(link->link_enc))
return false;
+ /* Check for FEC status*/
Missing space before `*/`.
+ if (link->link_enc->funcs->fec_is_active(link->link_enc))
+ return false;
+
enc_inst = link->link_enc->funcs->get_dig_frontend(link->link_enc);
if (enc_inst == ENGINE_ID_UNKNOWN)
I just saw, that this patch was committed on March 25th, 2022 (commit
7d56a154e22f) with my comments ignored. Could you please explain why?
Kind regards,
Paul
