Re: [PATCH] drm/amdkfd: shrink bitmap size in struct svm_validate_context

[Felix Kuehling <felix.kuehling@xxxxxxx>]

Am 2022-04-11 um 23:06 schrieb Lang Yu:
> A MAX_GPU_INSTANCE bits bitmap will suffice.
>
> Signed-off-by: Lang Yu <Lang.Yu@xxxxxxx>

Thanks for catching that. The patch is

Reviewed-by: Felix Kuehling <Felix.Kuehling@xxxxxxx>


> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> index 8b6adc142e25..459fa07a3bcc 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> @@ -1370,7 +1370,7 @@ struct svm_validate_context {
>   	struct kfd_process *process;
>   	struct svm_range *prange;
>   	bool intr;
> -	unsigned long bitmap[MAX_GPU_INSTANCE];
> +	DECLARE_BITMAP(bitmap, MAX_GPU_INSTANCE);
>   	struct ttm_validate_buffer tv[MAX_GPU_INSTANCE];
>   	struct list_head validate_list;
>   	struct ww_acquire_ctx ticket;