Re: [PATCH 01/20] drm/amd/display: undo clearing of z10 related function pointers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Eric, dear Pavle,


Thank you for the patch.

Am 08.04.22 um 19:18 schrieb Pavle Kotarac:
From: Eric Yang <Eric.Yang2@xxxxxxx>

[Why]
Z10 and S0i3 have some shared path. Previous code clean up ,

1.  cleanup
2.  Remove the space before the comma, or remove the unneeded comma.

incorrectly removed these pointers, which breaks s0i3 restore

Please add a dot/period at the end of sentences.

How does tho breakage manifest exactly?

Maybe mention, that it only happened with `dc->debug.disable_z10`.


[How]
Do not clear the function pointers based on Z10 disable.


What commit introduced the regression? Please add a Fixes tag.

Reviewed-by: Nicholas Kazlauskas <Nicholas.Kazlauskas@xxxxxxx>
Acked-by: Pavle Kotarac <Pavle.Kotarac@xxxxxxx>
Signed-off-by: Eric Yang <Eric.Yang2@xxxxxxx>
---
  drivers/gpu/drm/amd/display/dc/dcn31/dcn31_init.c | 5 -----
  1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_init.c b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_init.c
index d7559e5a99ce..e708f07fe75a 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_init.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_init.c
@@ -153,9 +153,4 @@ void dcn31_hw_sequencer_construct(struct dc *dc)
  		dc->hwss.init_hw = dcn20_fpga_init_hw;
  		dc->hwseq->funcs.init_pipes = NULL;
  	}
-	if (dc->debug.disable_z10) {
-		/*hw not support z10 or sw disable it*/
-		dc->hwss.z10_restore = NULL;
-		dc->hwss.z10_save_init = NULL;
-	}
  }


Kind regards,

Paul



[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux