[AMD Official Use Only] Dear Paul, Thank for review. Added comment inline. Regards, Mohammad >-----Original Message----- >From: Paul Menzel <pmenzel@xxxxxxxxxxxxx> >Sent: Monday, March 28, 2022 12:09 PM >To: Ziya, Mohammad zafar <Mohammadzafar.Ziya@xxxxxxx> >Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Zhou1, Tao <Tao.Zhou1@xxxxxxx>; >Lazar, Lijo <Lijo.Lazar@xxxxxxx>; Zhang, Hawking ><Hawking.Zhang@xxxxxxx> >Subject: Re: [PATCH v4 0/6] VCN and JPEG RAS poison detection > >Dear Mahommad, > > >Am 28.03.22 um 08:24 schrieb Mohammad Zafar Ziya: >> VCN and JPEG RAS poison detection > >It’d be great if you extended this a little bit. Especially, how it can be tested. [Mohammad]: This is the first series of the RAS poison consumption detection support, where this series only detects the poison consumption. The Interrupt from VCN/JPEG block will be intercepted and check the poison consumed by VCN/JPEG and cross check it is indeed the vcn/jpeg poison consumption interrupt. > >> Mohammad Zafar Ziya (6): >> drm/amdgpu: Add vcn and jpeg ras support flag >> drm/amdgpu/vcn: Add vcn ras support >> drm/amdgpu/jpeg: Add jpeg block ras support >> drm/amdgpu/vcn: vcn and jpeg ver 2.6 ras register definition >> drm/amdgpu/vcn: VCN ras error query support >> drm/amdgpu/jpeg: jpeg ras error query support > >It’d be great if you made the last three commit message summaries also >statements (by adding a verb in imperative mood). [Mohammad]: The 2nd last and last commit only facilitate the functionality of the poison consumption detection of the vcn/jpeg block. This will be called under IH/BH to check indeed interrupt from VCN/JPEG poison consumption. The 3rd last commits only add the register definition needed to facilitate the functionality. > > >Kind regards, > >Paul
