RE: [PATCH] drm/amdgpu/display: change pipe policy for DCN 2.1

["Wheeler, Daniel" <Daniel.Wheeler@xxxxxxx>]

[Public]

I never saw the hang with my testing, not sure if anyone else happened to see it. I'm not opposed to including the line.

Thank you,

Dan Wheeler
Technologist  |  AMD
SW Display
------------------------------------------------------------------------------------------------------------------
1 Commerce Valley Dr E, Thornhill, ON L3T 7X6
Facebook |  Twitter |  amd.com  


-----Original Message-----
From: Alex Deucher <alexdeucher@xxxxxxxxx> 
Sent: March 25, 2022 2:11 PM
To: Benjamin Marty <info@xxxxxxxxxxxxxxxx>; Siqueira, Rodrigo <Rodrigo.Siqueira@xxxxxxx>; Wheeler, Daniel <Daniel.Wheeler@xxxxxxx>
Cc: amd-gfx list <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] drm/amdgpu/display: change pipe policy for DCN 2.1

@Wheeler, Daniel
 @Siqueira, Rodrigo were you able to repro this?  Any ideas?  Any downsides to picking this up for now?

Alex

On Wed, Mar 23, 2022 at 5:18 PM Benjamin Marty <info@xxxxxxxxxxxxxxxx> wrote:
>
> Fixes crash on MST Hub disconnect.
>
> Bug: 
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitl
> ab.freedesktop.org%2Fdrm%2Famd%2F-%2Fissues%2F1849&amp;data=04%7C01%7C
> Daniel.Wheeler%40amd.com%7C21ed4881f6604db48b0208da0e8ae079%7C3dd8961f
> e4884e608e11a82d994e183d%7C0%7C0%7C637838286884708200%7CUnknown%7CTWFp
> bGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn
> 0%3D%7C3000&amp;sdata=9cpmXVrAtmDeAe2VMzcgT7%2B%2BYwmwEOb40fLuY7%2F5dJ
> o%3D&amp;reserved=0
> Fixes: ee2698cf79cc ("drm/amd/display: Changed pipe split policy to 
> allow for multi-display pipe split")
> Signed-off-by: Benjamin Marty <info@xxxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c 
> b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> index e5cc6bf45743..ca1bbc942fd4 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> @@ -873,7 +873,7 @@ static const struct dc_debug_options debug_defaults_drv = {
>                 .clock_trace = true,
>                 .disable_pplib_clock_request = true,
>                 .min_disp_clk_khz = 100000,
> -               .pipe_split_policy = MPC_SPLIT_DYNAMIC,
> +               .pipe_split_policy = MPC_SPLIT_AVOID_MULT_DISP,
>                 .force_single_disp_pipe_split = false,
>                 .disable_dcc = DCC_ENABLE,
>                 .vsr_support = true,
> --
> 2.35.1
>