Seems fine to me.
Series is reviewed-by: Evan Quan <evan.quan@xxxxxxx>
Thanks,
Evan
From: Powell, Darren <Darren.Powell@xxxxxxx>
Sent: Friday, March 25, 2022 4:24 AM
To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Cc: Quan, Evan <Evan.Quan@xxxxxxx>
Subject: Re: [PATCH v1 0/2] amdgpu/pm: Implement parallel sysfs_emit solution for vega10
[AMD Official Use Only]
PING?
[PATCH v1 0/2] amdgpu/pm: Implement parallel sysfs_emit solution for vega10
2022-03-13 5:28 UTC (3+ messages)
` [PATCH 1/2] amdgpu/pm: Add new hwmgr API function "emit_clock_levels"
` [PATCH 2/2] amdgpu/pm: Implement emit_clk_levels for vega10
Darren
== Description ==
Scnprintf use within the kernel is not recommended, but simple sysfs_emit replacement has
not been successful due to the page alignment requirement of the function. This patch
set implements a new api "emit_clock_levels" to facilitate passing both the base and
offset to the device rather than just the write pointer.
The emit_clock_levels API for amdgpu_dpm has been duplicated to pp_dpm, based on the patch
commit 7f36948c92b2 ("amdgpu/pm: Implement new API function "emit" that accepts buffer base and write offset")
and vega10_emit_clock_levels has been implemented with sysfs_emit based on vega10_print_clock_levels
== Patch Summary ==
linux: (git@xxxxxxxxxxxxxxxxxxxxxx:agd5f) origin/amd-staging-drm-next @ 6b6b9c625004
+ e94021f6c08c amdgpu/pm: Add new hwmgr API function "emit_clock_levels"
+ d83131987718 amdgpu/pm: Implement emit_clk_levels for vega10
== System Summary ==
* DESKTOP(AMD FX-8350 + VEGA10(687f/c3), BIOS: F2)
+ ISO(Ubuntu 20.04.4 LTS)
+ Kernel(5.16.0-20220307-fdoagd5f-g6b6b9c625004)
+ Overdrive Enabled(amdgpu.ppfeaturemask |= 0x4000)
== Test ==
AMDGPU_PCI_ADDR=`lspci -nn | grep "VGA\|Display" | cut -d " " -f 1`
AMDGPU_HWMON=`ls -la /sys/class/hwmon | grep $AMDGPU_PCI_ADDR | awk '{print $9}'`
HWMON_DIR=/sys/class/hwmon/${AMDGPU_HWMON}
lspci -nn | grep "VGA\|Display" > $LOGFILE
printf 'OD enabled = %X\n' "$(( `cat /sys/module/amdgpu/parameters/ppfeaturemask` & 0x4000 ))" >> $LOGFILE
FILES="pp_od_clk_voltage
pp_dpm_sclk
pp_dpm_mclk
pp_dpm_pcie
pp_dpm_socclk
pp_dpm_fclk
pp_dpm_dcefclk
pp_dpm_vclk
pp_dpm_dclk "
for f in $FILES
do
echo === $f === >> $LOGFILE
cat $HWMON_DIR/device/$f >> $LOGFILE
done
cat $LOGFILE
Darren Powell (2):
amdgpu/pm: Add new hwmgr API function "emit_clock_levels"
amdgpu/pm: Implement emit_clk_levels for vega10
.../gpu/drm/amd/pm/powerplay/amd_powerplay.c | 17 ++
.../drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c | 147 ++++++++++++++++++
drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h | 2 +
3 files changed, 166 insertions(+)
base-commit: 6b6b9c625004e07e000ca1918cadcb64439eb498
--
2.35.1
|
