[AMD Official Use Only] Thanks Luben, I've added my Rb and pushed out the series to main. Cheers, Tom ________________________________________ From: Tuikov, Luben <Luben.Tuikov@xxxxxxx> Sent: Wednesday, March 23, 2022 07:48 To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx Cc: Tuikov, Luben; Deucher, Alexander; Pelloux-Prayer, Pierre-Eric; StDenis, Tom; Koenig, Christian Subject: [PATCH 0/6] Complete and add dynamic completion to umr Complete and add dynamic completion to umr. Some of the difficulties seen in this work were, *) slightly different output of sysfs files depending on the system configuration and the number of controllers in the system. *) Merging of the IP Discovery sysfs discovery mechanism. *) The varied and finicky user input strings. This work was tested on two different systems with different ASICs, with three distinct configurations, one of which includes two different AMD GPU controllers in the same system. Luben Tuikov (6): umr: Rename "scripts/umr" --> "scripts/umr-completion.bash" umr: Rename completion function umr: Complete umr completion umr: Replace and reuse asic.ipblock.reg completion umr: Replace and reuse ipblock completion umr: Add FILES section to the man page Cc: Alex Deucher <Alexander.Deucher@xxxxxxx> Cc: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@xxxxxxx> Cc: Tom StDenis <tom.stdenis@xxxxxxx> Cc: Christian König <christian.koenig@xxxxxxx> doc/umr.1 | 13 +- scripts/umr | 83 -------- scripts/umr-completion.bash | 402 ++++++++++++++++++++++++++++++++++++ src/app/CMakeLists.txt | 2 +- 4 files changed, 414 insertions(+), 86 deletions(-) delete mode 100644 scripts/umr create mode 100644 scripts/umr-completion.bash base-commit: d773ac6b1f529c02d8d2021d69e2dcfad736628d -- 2.35.1.607.gf01e51a7cf