Re: [PATCH] drm/amdkfd: print unmap queue status for RAS poison consumption (v3)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Tao,


Thank you for rerolling the pacth.

Am 22.03.22 um 04:29 schrieb Tao Zhou:
Print the status out when it passes, and also tell user gpu reset
is triggered when we fallback to legacy way.

The verb *fall back* is written with a space.

v2: make the message more explicitly.

explicit

v3: change succeeds to succeeded.
     replace pr_warn with dev_info.

Please give the reason, why to decrease the debug level. (I would also do it in a separate commit.)

Signed-off-by: Tao Zhou <tao.zhou1@xxxxxxx>
---
  drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c | 13 +++++++++----
  1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c b/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c
index 56902b5bb7b6..cc9ddc4b4cb8 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c
@@ -105,8 +105,6 @@ static void event_interrupt_poison_consumption(struct kfd_dev *dev,
  	if (old_poison)
  		return;
- pr_warn("RAS poison consumption handling: client id %d\n", client_id);
-
  	switch (client_id) {
  	case SOC15_IH_CLIENTID_SE0SH:
  	case SOC15_IH_CLIENTID_SE1SH:
@@ -130,10 +128,17 @@ static void event_interrupt_poison_consumption(struct kfd_dev *dev,
  	/* resetting queue passes, do page retirement without gpu reset
  	 * resetting queue fails, fallback to gpu reset solution
  	 */
-	if (!ret)
+	if (!ret) {
+		dev_info(dev->adev->dev,
+			"RAS poison consumption, unmap queue flow succeeded: client id %d\n",
+			client_id);
  		amdgpu_amdkfd_ras_poison_consumption_handler(dev->adev, false);
-	else
+	} else {
+		dev_info(dev->adev->dev,
+			"RAS poison consumption, fallback to gpu reset flow: client id %d\n",

The verb *fall back* is written with a space.

+			client_id);
  		amdgpu_amdkfd_ras_poison_consumption_handler(dev->adev, true);
+	}
  }
static bool event_interrupt_isr_v9(struct kfd_dev *dev,



[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux