Re: [PATCH 10/13] drm/amd/display: remove destructive verify link for TMDS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Alex, dear Charlene,


Thank you for the patch.

Am 18.03.22 um 22:47 schrieb Alex Hung:
From: Charlene Liu <Charlene.Liu@xxxxxxx>

[why and how]
TMDS not need destructive verify link

According to whom? Please document the source for that claim.

Is that just to be spec compliant, or does it cause an actual problem? If so, how can it be reproduced?

Reviewed-by: Aric Cyr <Aric.Cyr@xxxxxxx>
Acked-by: Alan Liu <HaoPing.Liu@xxxxxxx>
Acked-by: Alex Hung <alex.hung@xxxxxxx>
Signed-off-by: Charlene Liu <Charlene.Liu@xxxxxxx>
---
  drivers/gpu/drm/amd/display/dc/core/dc_link.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
index cb87dd643180..bbaa5abdf888 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
@@ -983,8 +983,7 @@ static bool should_verify_link_capability_destructively(struct dc_link *link,
  				destrictive = false;
  			}
  		}
-	} else if (dc_is_hdmi_signal(link->local_sink->sink_signal))
-		destrictive = true;
+	}
return destrictive;
  }

It’d be great, if you also sent a patch to fix the typo in the variable name.


Kind regards,

Paul



[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux