Re: [PATCH 1/3] drm/amdgpu: make amdgpu_display_framebuffer_init() static

[Aurabindo Pillai <aurabindo.pillai@xxxxxxx>]

Series is

Reviewed-by: Aurabindo Pillai <aurabindo.pillai@xxxxxxx>

On 2022-03-15 13:09, Alex Deucher wrote:
> It's not used outside of amdgpu_display.c.
>
> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 13 +++++++++----
>   drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h    |  4 ----
>   2 files changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> index 70be09dd2a93..cb78ba396672 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> @@ -41,6 +41,11 @@
>   #include <drm/drm_fourcc.h>
>   #include <drm/drm_vblank.h>
>   
> +static int amdgpu_display_framebuffer_init(struct drm_device *dev,
> +					   struct amdgpu_framebuffer *rfb,
> +					   const struct drm_mode_fb_cmd2 *mode_cmd,
> +					   struct drm_gem_object *obj);
> +
>   static void amdgpu_display_flip_callback(struct dma_fence *f,
>   					 struct dma_fence_cb *cb)
>   {
> @@ -1097,10 +1102,10 @@ int amdgpu_display_gem_fb_verify_and_init(
>   	return ret;
>   }
>   
> -int amdgpu_display_framebuffer_init(struct drm_device *dev,
> -				    struct amdgpu_framebuffer *rfb,
> -				    const struct drm_mode_fb_cmd2 *mode_cmd,
> -				    struct drm_gem_object *obj)
> +static int amdgpu_display_framebuffer_init(struct drm_device *dev,
> +					   struct amdgpu_framebuffer *rfb,
> +					   const struct drm_mode_fb_cmd2 *mode_cmd,
> +					   struct drm_gem_object *obj)
>   {
>   	struct amdgpu_device *adev = drm_to_adev(dev);
>   	int ret, i;
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
> index 28848f1348a8..69ce2eeb782e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
> @@ -600,10 +600,6 @@ int amdgpu_display_gem_fb_verify_and_init(
>   	struct drm_device *dev, struct amdgpu_framebuffer *rfb,
>   	struct drm_file *file_priv, const struct drm_mode_fb_cmd2 *mode_cmd,
>   	struct drm_gem_object *obj);
> -int amdgpu_display_framebuffer_init(struct drm_device *dev,
> -				    struct amdgpu_framebuffer *rfb,
> -				    const struct drm_mode_fb_cmd2 *mode_cmd,
> -				    struct drm_gem_object *obj);
>   
>   int amdgpufb_remove(struct drm_device *dev, struct drm_framebuffer *fb);
>