Applied. Thanks!
On Mon, Mar 14, 2022 at 2:28 AM Zhou1, Tao <Tao.Zhou1@xxxxxxx> wrote:
>
> [AMD Official Use Only]
>
> Reviewed-by: Tao Zhou <tao.zhou1@xxxxxxx>
>
> > -----Original Message-----
> > From: Chai, Thomas <YiPeng.Chai@xxxxxxx>
> > Sent: Monday, March 14, 2022 1:52 PM
> > To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> > Cc: Chai, Thomas <YiPeng.Chai@xxxxxxx>; Zhang, Hawking
> > <Hawking.Zhang@xxxxxxx>; Zhou1, Tao <Tao.Zhou1@xxxxxxx>; Clements,
> > John <John.Clements@xxxxxxx>; Chai, Thomas <YiPeng.Chai@xxxxxxx>
> > Subject: [PATCH] drm/amdgpu: fixed the warnings reported by kernel test robot
> >
> > The reported warnings are as follows:
> > 1.warning:no-previous-prototype-for-amdgpu_hdp_ras_fini.
> > 2.warning:no-previous-prototype-for-amdgpu_mmhub_ras_fini.
> >
> > Amdgpu_hdp_ras_fini and amdgpu_mmhub_ras_fini are unused in the code,
> > they are the only functions in amdgpu_hdp.c and amdgpu_mmhub.c. After
> > removing these two functions, both amdgpu_hdp.c and amdgpu_mmhub.c are
> > empty, so these two files can be deleted to fix the warning.
> >
> > Signed-off-by: yipechai <YiPeng.Chai@xxxxxxx>
> > ---
> > drivers/gpu/drm/amd/amdgpu/Makefile | 4 +--
> > drivers/gpu/drm/amd/amdgpu/amdgpu_hdp.c | 30 -----------------------
> > drivers/gpu/drm/amd/amdgpu/amdgpu_mmhub.c | 30 -----------------------
> > 3 files changed, 2 insertions(+), 62 deletions(-) delete mode 100644
> > drivers/gpu/drm/amd/amdgpu/amdgpu_hdp.c
> > delete mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_mmhub.c
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/Makefile
> > b/drivers/gpu/drm/amd/amdgpu/Makefile
> > index 5dfe08cb045e..40e2c6e2df79 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/Makefile
> > +++ b/drivers/gpu/drm/amd/amdgpu/Makefile
> > @@ -53,11 +53,11 @@ amdgpu-y += amdgpu_device.o amdgpu_kms.o \
> > amdgpu_ucode.o amdgpu_bo_list.o amdgpu_ctx.o amdgpu_sync.o \
> > amdgpu_gtt_mgr.o amdgpu_preempt_mgr.o amdgpu_vram_mgr.o
> > amdgpu_virt.o \
> > amdgpu_atomfirmware.o amdgpu_vf_error.o amdgpu_sched.o \
> > - amdgpu_debugfs.o amdgpu_ids.o amdgpu_gmc.o amdgpu_mmhub.o \
> > + amdgpu_debugfs.o amdgpu_ids.o amdgpu_gmc.o \
> > amdgpu_xgmi.o amdgpu_csa.o amdgpu_ras.o amdgpu_vm_cpu.o \
> > amdgpu_vm_sdma.o amdgpu_discovery.o amdgpu_ras_eeprom.o
> > amdgpu_nbio.o \
> > amdgpu_umc.o smu_v11_0_i2c.o amdgpu_fru_eeprom.o
> > amdgpu_rap.o \
> > - amdgpu_fw_attestation.o amdgpu_securedisplay.o amdgpu_hdp.o \
> > + amdgpu_fw_attestation.o amdgpu_securedisplay.o \
> > amdgpu_eeprom.o amdgpu_mca.o
> >
> > amdgpu-$(CONFIG_PROC_FS) += amdgpu_fdinfo.o diff --git
> > a/drivers/gpu/drm/amd/amdgpu/amdgpu_hdp.c
> > b/drivers/gpu/drm/amd/amdgpu/amdgpu_hdp.c
> > deleted file mode 100644
> > index 3f3d92e16c2e..000000000000
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_hdp.c
> > +++ /dev/null
> > @@ -1,30 +0,0 @@
> > -/*
> > - * Copyright 2021 Advanced Micro Devices, Inc.
> > - *
> > - * Permission is hereby granted, free of charge, to any person obtaining a
> > - * copy of this software and associated documentation files (the "Software"),
> > - * to deal in the Software without restriction, including without limitation
> > - * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> > - * and/or sell copies of the Software, and to permit persons to whom the
> > - * Software is furnished to do so, subject to the following conditions:
> > - *
> > - * The above copyright notice and this permission notice shall be included in
> > - * all copies or substantial portions of the Software.
> > - *
> > - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > EXPRESS OR
> > - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> > MERCHANTABILITY,
> > - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO
> > EVENT SHALL
> > - * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM,
> > DAMAGES OR
> > - * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
> > OTHERWISE,
> > - * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
> > USE OR
> > - * OTHER DEALINGS IN THE SOFTWARE.
> > - *
> > - */
> > -
> > -#include "amdgpu.h"
> > -#include "amdgpu_ras.h"
> > -
> > -void amdgpu_hdp_ras_fini(struct amdgpu_device *adev, struct ras_common_if
> > *ras_block) -{
> > -
> > -}
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mmhub.c
> > b/drivers/gpu/drm/amd/amdgpu/amdgpu_mmhub.c
> > deleted file mode 100644
> > index 8f2fa247d605..000000000000
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mmhub.c
> > +++ /dev/null
> > @@ -1,30 +0,0 @@
> > -/*
> > - * Copyright 2019 Advanced Micro Devices, Inc.
> > - *
> > - * Permission is hereby granted, free of charge, to any person obtaining a
> > - * copy of this software and associated documentation files (the "Software"),
> > - * to deal in the Software without restriction, including without limitation
> > - * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> > - * and/or sell copies of the Software, and to permit persons to whom the
> > - * Software is furnished to do so, subject to the following conditions:
> > - *
> > - * The above copyright notice and this permission notice shall be included in
> > - * all copies or substantial portions of the Software.
> > - *
> > - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > EXPRESS OR
> > - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> > MERCHANTABILITY,
> > - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO
> > EVENT SHALL
> > - * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM,
> > DAMAGES OR
> > - * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
> > OTHERWISE,
> > - * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
> > USE OR
> > - * OTHER DEALINGS IN THE SOFTWARE.
> > - *
> > - */
> > -
> > -#include "amdgpu.h"
> > -#include "amdgpu_ras.h"
> > -
> > -void amdgpu_mmhub_ras_fini(struct amdgpu_device *adev, struct
> > ras_common_if *ras_block) -{
> > -
> > -}
> > --
> > 2.25.1
