Thanks for your review, Christian. I will send an updated patch set soon. How about patch 1 in my series "[PATCH 1/2] drm/amdgpu: prevent memory wipe in suspend/shutdown stage"? Regards, Guchun -----Original Message----- From: Koenig, Christian <Christian.Koenig@xxxxxxx> Sent: Tuesday, March 15, 2022 3:22 PM To: Chen, Guchun <Guchun.Chen@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Zhang, Hawking <Hawking.Zhang@xxxxxxx>; Pan, Xinhui <Xinhui.Pan@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx> Subject: Re: [PATCH 2/2] drm/amdgpu: fix pin count leak of PDB bo when unref Am 15.03.22 um 08:11 schrieb Guchun Chen: > Use amdgpu_bo_free_kernel instead of amdgpu_bo_unref to perform a > clean unreference job. I think the subject is incorrect. This doesn't leak the pin count, but rather produces a warning that the BO needs a proper cleanup. > Signed-off-by: Guchun Chen <guchun.chen@xxxxxxx> With the subject line re-validated the patch is Reviewed-by: Christian König <christian.koenig@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c > b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c > index 431742eb7811..e4e7e6dbc6fb 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c > @@ -1721,7 +1721,7 @@ static int gmc_v9_0_sw_fini(void *handle) > amdgpu_gem_force_release(adev); > amdgpu_vm_manager_fini(adev); > amdgpu_gart_table_vram_free(adev); > - amdgpu_bo_unref(&adev->gmc.pdb0_bo); > + amdgpu_bo_free_kernel(&adev->gmc.pdb0_bo, NULL, adev->gmc.ptr_pdb0); > amdgpu_bo_fini(adev); > > return 0;
