Hi, Maybe it would be a good idea to state the intended use-case in the commit message? And explain why the current (driver-specific IIRC) APIs aren't enough? Since this introduces new uAPI, can you point to a user-space patch which uses the new uAPI? See this link for more info on DRM user-space requirements: https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#open-source-userspace-requirements Please use drm_dbg_* and drm_warn_* helpers instead of DRM_DEBUG and DRM_WARN. This allows identifying on which device the uevent happens. On Tuesday, March 8th, 2022 at 19:04, Shashank Sharma <contactshashanksharma@xxxxxxxxx> wrote: > +void drm_sysfs_reset_event(struct drm_device *dev, struct drm_reset_event *reset_info) reset_info can be const.
