On Thu, Feb 24, 2022 at 4:46 PM Luben Tuikov <luben.tuikov@xxxxxxx> wrote:
>
> Don't fill up the logs with:
>
> [253557.859575] [drm:amdgpu_dm_atomic_check [amdgpu]] DSC precompute is not needed.
> [253557.892966] [drm:amdgpu_dm_atomic_check [amdgpu]] DSC precompute is not needed.
> [253557.926070] [drm:amdgpu_dm_atomic_check [amdgpu]] DSC precompute is not needed.
> [253557.959344] [drm:amdgpu_dm_atomic_check [amdgpu]] DSC precompute is not needed.
>
> which prints many times a second, when the kernel is run with
> drm.debug=2.
>
> Instead of DRM_DEBUG_DRIVER(), make it DRM_INFO_ONCE().
Maybe convert to DRM_DEBUG_KMS() for consistency with the rest of the
display code?
Alex
>
> Cc: Alex Deucher <Alexander.Deucher@xxxxxxx>
> Cc: Roman Li <Roman.Li@xxxxxxx>
> Cc: Felix Kuehling <felix.kuehling@xxxxxxx>
> Cc: Hersen Wu <hersenwu@xxxxxxx>
> Cc: Daniel Wheeler <daniel.wheeler@xxxxxxx>
> Fixes: 5898243ba7acdb ("drm/amd/display: Add dsc pre-validation in atomic check")
> Signed-off-by: Luben Tuikov <luben.tuikov@xxxxxxx>
> ---
> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> index 05573f073b21f7..0542034530b1b0 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> @@ -1198,11 +1198,11 @@ void pre_validate_dsc(struct drm_atomic_state *state,
> struct dc_state *local_dc_state = NULL;
>
> if (!is_dsc_precompute_needed(state)) {
> - DRM_DEBUG_DRIVER("DSC precompute is not needed.\n");
> + DRM_INFO_ONCE("DSC precompute is not needed.\n");
> return;
> }
> if (dm_atomic_get_state(state, dm_state_ptr)) {
> - DRM_DEBUG_DRIVER("dm_atomic_get_state() failed\n");
> + DRM_INFO_ONCE("dm_atomic_get_state() failed\n");
> return;
> }
> dm_state = *dm_state_ptr;
> @@ -1245,7 +1245,7 @@ void pre_validate_dsc(struct drm_atomic_state *state,
> }
>
> if (!pre_compute_mst_dsc_configs_for_state(state, local_dc_state, vars)) {
> - DRM_DEBUG_DRIVER("pre_compute_mst_dsc_configs_for_state() failed\n");
> + DRM_INFO_ONCE("pre_compute_mst_dsc_configs_for_state() failed\n");
> goto clean_exit;
> }
>
> @@ -1258,7 +1258,7 @@ void pre_validate_dsc(struct drm_atomic_state *state,
>
> if (local_dc_state->streams[i] &&
> is_timing_changed(stream, local_dc_state->streams[i])) {
> - DRM_DEBUG_DRIVER("crtc[%d] needs mode_changed\n", i);
> + DRM_INFO_ONCE("crtc[%d] needs mode_changed\n", i);
> } else {
> int ind = find_crtc_index_in_state_by_stream(state, stream);
>
>
> base-commit: bff980c7632ef3b0099ba230cf7d5c864db3e1a3
> --
> 2.35.1.129.gb80121027d
>
