Re: [PATCH 7/7] drm/amdgpu: drop testing module parameter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Am 22.02.22 um 10:07 schrieb Michel Dänzer:
On 2022-02-21 22:35, Alex Deucher wrote:
On Mon, Feb 21, 2022 at 12:44 PM Michel Dänzer
<michel.daenzer@xxxxxxxxxxx> wrote:
On 2022-02-18 23:26, Alex Deucher wrote:
This was always duplicate functionality with the benchmark tests.
Not really. The purpose of amdgpu_do_test_moves is testing that copies between GTT & VRAM work across the whole GTT aperture (when I originally wrote radeon_do_test_moves, they didn't on the PowerBook I was using at the time).

Fair enough.  I'll drop it for now.  Might be useful to convert to
debugfs at some point as well.
To be clear, I'm not saying this needs to stay — maybe it's not useful anymore. I'm just pointing out that it's not redundant with the benchmarks.

Yeah, the test doesn't necessary work that well any more since we now have the GART table much smaller than the GTT size.

I think it's still the best to just remove that.

Regards,
Christian.



[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux