[AMD Official Use Only] Hi Christian, We'd like to enable display S/G only for APUs which have smaller VRAM. If >= IP_VERSION(3, 1, 0) is used, new dGPUs will be included. That's not our intention. BRs, Yifan -----Original Message----- From: Christian König <ckoenig.leichtzumerken@xxxxxxxxx> Sent: Tuesday, February 22, 2022 2:15 AM To: Alex Deucher <alexdeucher@xxxxxxxxx>; Zhang, Yifan <Yifan1.Zhang@xxxxxxx> Cc: Li, Sun peng (Leo) <Sunpeng.Li@xxxxxxx>; Yin, Tianci (Rico) <Tianci.Yin@xxxxxxx>; Wentland, Harry <Harry.Wentland@xxxxxxx>; amd-gfx list <amd-gfx@xxxxxxxxxxxxxxxxxxxxx> Subject: Re: [PATCH] drm/amd/display: add GTT domain support for dcn 3.1.5 Am 21.02.22 um 15:27 schrieb Alex Deucher: > On Mon, Feb 21, 2022 at 5:15 AM Yifan Zhang <yifan1.zhang@xxxxxxx> wrote: >> From: "Tianci.Yin" <tianci.yin@xxxxxxx> >> >> this patch adds GTT domain support for dcn 3.1.5 >> >> Signed-off-by: Tianci.Yin <tianci.yin@xxxxxxx> >> Signed-off-by: Yifan Zhang <yifan1.zhang@xxxxxxx> >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c >> b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c >> index 9709368b4915..88ee1224541c 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c >> @@ -523,6 +523,7 @@ uint32_t amdgpu_display_supported_domains(struct amdgpu_device *adev, >> case IP_VERSION(3, 0, 1): >> case IP_VERSION(3, 1, 2): >> case IP_VERSION(3, 1, 3): >> + case IP_VERSION(3, 1, 5): > Should also add 3.1.6 as well? I'm really wondering if that check shouldn't be something like >= IP_VERSION(3, 1, 0) instead. Christian. > > Alex > > >> domain |= AMDGPU_GEM_DOMAIN_GTT; >> break; >> default: >> -- >> 2.25.1 >>
