[AMD Official Use Only]
Yifan,
Please remove Change-Id.
With this fixed, Acked-by: Aaron Liu <aaron.liu@xxxxxxx>
--
Best Regards
Aaron Liu
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Yifan
> Zhang
> Sent: Monday, February 14, 2022 12:12 PM
> To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Zhang, Yifan
> <Yifan1.Zhang@xxxxxxx>; Liu, Aaron <Aaron.Liu@xxxxxxx>
> Subject: [PATCH] drm/amd/pm: correct the sequence of sending gpu reset
> msg
>
> the 2nd parameter should be smu msg type rather than asic msg index.
>
> Signed-off-by: Yifan Zhang <yifan1.zhang@xxxxxxx>
> Change-Id: I0a65fac53b06c053ce193580d68cf586e77d2c2d
> ---
> drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c
> b/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c
> index e90387a84cbb..e2d099409123 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c
> @@ -262,14 +262,9 @@ static int yellow_carp_post_smu_init(struct
> smu_context *smu)
>
> static int yellow_carp_mode_reset(struct smu_context *smu, int type) {
> - int ret = 0, index = 0;
> -
> - index = smu_cmn_to_asic_specific_index(smu,
> CMN2ASIC_MAPPING_MSG,
> - SMU_MSG_GfxDeviceDriverReset);
> - if (index < 0)
> - return index == -EACCES ? 0 : index;
> + int ret = 0;
>
> - ret = smu_cmn_send_smc_msg_with_param(smu, (uint16_t)index,
> type, NULL);
> + ret = smu_cmn_send_smc_msg_with_param(smu,
> +SMU_MSG_GfxDeviceDriverReset, type, NULL);
> if (ret)
> dev_err(smu->adev->dev, "Failed to mode reset!\n");
>
> --
> 2.25.1
