[Public]
Hi Eric,
Are you sure that there is no FW requirement for this patch on Vega20? KFDMemory test failed by this commit.
Regards,
Guchun
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Alex Deucher
Sent: Tuesday, January 25, 2022 4:08 AM
To: Huang, JinHuiEric <JinHuiEric.Huang@xxxxxxx>
Cc: amd-gfx list <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Vega20
On Fri, Jan 21, 2022 at 11:17 AM Eric Huang <jinhuieric.huang@xxxxxxx> wrote:
>
> It is to meet the requirement for memory allocation optimization on
> MI50.
>
> Signed-off-by: Eric Huang <jinhuieric.huang@xxxxxxx>
Assuming there is no firmware version requirement, the patch is:
Acked-by: Alex Deucher <alexander.deucher@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> index 5b8ae0795c0a..d708f1a502cf 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> @@ -1582,7 +1582,8 @@ static int kfd_ioctl_free_memory_of_gpu(struct
> file *filep, static bool kfd_flush_tlb_after_unmap(struct kfd_dev *dev) {
> return KFD_GC_VERSION(dev) == IP_VERSION(9, 4, 2) ||
> (KFD_GC_VERSION(dev) == IP_VERSION(9, 4, 1) &&
> - dev->adev->sdma.instance[0].fw_version >= 18);
> + dev->adev->sdma.instance[0].fw_version >= 18) ||
> + KFD_GC_VERSION(dev) == IP_VERSION(9, 4, 0);
> }
>
> static int kfd_ioctl_map_memory_to_gpu(struct file *filep,
> --
> 2.25.1
>
