Re: [PATCH] drm/amdgpu: fix list add issue in vram reserve

[Christian König <ckoenig.leichtzumerken@xxxxxxxxx>]

Am 30.01.22 um 08:37 schrieb Tao Zhou:
> The parameter order in the list_add_tail is incorrect, it causes the
> reuse of ras reserved page.
>
> Signed-off-by: Tao Zhou <tao.zhou1@xxxxxxx>

Good catch, Reviewed-by: Christian König <christian.koenig@xxxxxxx>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
> index 7a2b487db57c..6c99ef700cc8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
> @@ -281,7 +281,7 @@ int amdgpu_vram_mgr_reserve_range(struct amdgpu_vram_mgr *mgr,
>   	rsv->mm_node.size = size >> PAGE_SHIFT;
>   
>   	spin_lock(&mgr->lock);
> -	list_add_tail(&mgr->reservations_pending, &rsv->node);
> +	list_add_tail(&rsv->node, &mgr->reservations_pending);
>   	amdgpu_vram_mgr_do_reserve(&mgr->manager);
>   	spin_unlock(&mgr->lock);
>