On 1/28/22 08:06, Aditya Garg wrote:
Hi Alex
On 27-Jan-2022, at 11:06 PM, Alex Deucher <alexdeucher@xxxxxxxxx> wrote:
C style comments please.
Shall be fixed in v2
I'll let one of the display guys comment on
the rest of the patch. Seems reasonable, we have a similar quirk for
the Apple MBP 2017 15" Retina panel later in this function. Could you
move this next to the other quirk?
I guess moving it next to the other quirk may break the functionality of this quirk, cause the MBP 2018 one involves stuff regarding firmware revision as well. The original patch applies the quirk after the following lines of the code :-
core_link_read_dpcd(
link,
DP_SINK_HW_REVISION_START,
(uint8_t *)&dp_hw_fw_revision,
sizeof(dp_hw_fw_revision));
link->dpcd_caps.sink_hw_revision =
dp_hw_fw_revision.ieee_hw_rev;
memmove(
link->dpcd_caps.sink_fw_revision,
dp_hw_fw_revision.ieee_fw_rev,
sizeof(dp_hw_fw_revision.ieee_fw_rev));
Which seem to related to the firmware stuff. Moving it along with the 2017 quirk doesn't sound right to me, as this shall move the quirk BEFORE these lines of code instead. Maybe the author also knowingly added the quirk after these lines of code?
As a workaround, could we move the 2017 quirk later, instead of moving the 2018 quirk before? This sounds more logical to me.
I think either leaving the 2017 quirk in its original place or moving it
down works. I don't have a strong preference.
With the comment style addressed this patch is
Reviewed-by: Harry Wentland <harry.wentland@xxxxxxx>
Harry
Regards
Aditya
