Re: [PATCH] amd/amdkfd:Fix the return value in kfd_process_queue_manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Yes, return is not necessary here.
I'll apply this patch on dkms-staging to fix the compile
error.

On 1/20/2022 1:10 AM, Deucher, Alexander wrote:
> [AMD Official Use Only]
> 
> 
> You can just drop the whole line.
> 
> Alex
> 
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> *From:* amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> on behalf of majun <majun@xxxxxxx>
> *Sent:* Wednesday, January 19, 2022 7:57 AM
> *To:* amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>
> *Subject:* [PATCH] amd/amdkfd:Fix the return value in kfd_process_queue_manager
>  
> Change the return value of set_queue_properties_from_criu()
> 
> Signed-off-by: majun <majun@xxxxxxx>
> Change-Id: I11362eb76eee84e64c5207c24a2b78141f62e63a
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c
> index ec62897914da..f70e972d1d33 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c
> @@ -826,7 +826,7 @@ static void set_queue_properties_from_criu(struct queue_properties *qp,
>          qp->type = q_data->type;
>          qp->format = q_data->format;
>  
> -       return 0;
> +       return;
>  }
>  
>  
> -- 
> 2.25.1
> 




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux