On Wed, 19 Jan 2022 at 06:14, Eric Huang <jinhuieric.huang@xxxxxxx> wrote: > > I understand Alex's concern. I think usually we only check the version > when a feature is only available in a specific version, and other > version or newer version doesn't have. > > In case of FW fix, we assume the driver and FWs have to be synchronous. > If we have driver backward compatibility for FWs, there must be a lot of > redundant codes for FW version check. So this patch and SDMA fix will be > pushed into ROCm 5.1 release branch at the same time. > Please remove that assumption from everwhere. If you have released a fw into linux-firmware then you need to support it going forward, even if it means printing something in dmesg recommending people upgrade for features. Dave.
