On Mon, Jan 17, 2022 at 10:38:48AM +0100, Christian König wrote: > The return value was never initialized so the cleanup code executed when > it isn't even necessary. > > Just add proper error handling. > > Fixes: 2ad5d8fca195 ("drm/radeon/radeon_kms: Fix a NULL pointer dereference in radeon_driver_open_kms()") > Signed-off-by: Christian König <christian.koenig@xxxxxxx> > --- > drivers/gpu/drm/radeon/radeon_kms.c | 22 ++++++++++++---------- > 1 file changed, 12 insertions(+), 10 deletions(-) Looks good, box boots fine with it. Tested-by: Borislav Petkov <bp@xxxxxxx> Thx! -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette