On Mon, Jan 10, 2022 at 10:25:57AM +0800, Liang, Prike wrote: > In some APU project we needn't always assign flags to identify each other, > so we may not need return an error. > > Change-Id: I92c1acb9ffbdba7e9a68469163911801db262412 > Signed-off-by: Prike Liang <Prike.Liang@xxxxxxx> > Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx> Please remove the Change-Id. With that fixed, patch is Reviewed-by: Huang Rui <ray.huang@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index 4322d92c25c7..2a6671f37336 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -1449,7 +1449,7 @@ static int amdgpu_device_init_apu_flags(struct amdgpu_device *adev) > adev->apu_flags |= AMD_APU_IS_CYAN_SKILLFISH2; > break; > default: > - return -EINVAL; > + break; > } > > return 0; > @@ -3497,9 +3497,7 @@ int amdgpu_device_init(struct amdgpu_device *adev, > mutex_init(&adev->psp.mutex); > mutex_init(&adev->notifier_lock); > > - r = amdgpu_device_init_apu_flags(adev); > - if (r) > - return r; > + amdgpu_device_init_apu_flags(adev); > > r = amdgpu_device_check_arguments(adev); > if (r) > -- > 2.17.1 >
