[AMD Official Use Only]
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Alex
> Deucher
> Sent: Tuesday, December 21, 2021 10:59 PM
> To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>
> Subject: [PATCH] drm/amdgpu: fix runpm documentation
>
> It's not only supported by HG/PX laptops. It's supported
> by all dGPUs which supports BOCO/BACO functionality (runtime
> D3).
>
> BOCO - Bus Off, Chip Off. The entire chip is powered off.
> This is controlled by ACPI.
> BACO - Bus Active, Chip Off. The chip still shows up
> on the PCI bus, but the device itself is powered
> down.
>
> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index a78bbea9629d..f001924ed92e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -331,9 +331,10 @@ module_param_named(aspm, amdgpu_aspm, int,
> 0444);
> /**
> * DOC: runpm (int)
> * Override for runtime power management control for dGPUs in PX/HG
> laptops. The amdgpu driver can dynamically power down
[Quan, Evan] This("dGPUs in PX/HG latops") needs also be updated. Maybe missing unintentionally ?
With that fixed, the patch is reviewed-by: Evan Quan <evan.quan@xxxxxxx>
BR
Evan
> - * the dGPU on PX/HG laptops when it is idle. The default is -1 (auto enable).
> Setting the value to 0 disables this functionality.
> + * the dGPUs when they are idle if supported. The default is -1 (auto
> enable).
> + * Setting the value to 0 disables this functionality.
> */
> -MODULE_PARM_DESC(runpm, "PX runtime pm (2 = force enable with
> BAMACO, 1 = force enable with BACO, 0 = disable, -1 = PX only default)");
> +MODULE_PARM_DESC(runpm, "PX runtime pm (2 = force enable with
> BAMACO, 1 = force enable with BACO, 0 = disable, -1 = auto)");
> module_param_named(runpm, amdgpu_runtime_pm, int, 0444);
>
> /**
> --
> 2.33.1
