[AMD Official Use Only] Reviewed-by: Evan Quan <evan.quan@xxxxxxx> > -----Original Message----- > From: Lazar, Lijo <Lijo.Lazar@xxxxxxx> > Sent: Tuesday, December 14, 2021 3:13 PM > To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: Zhang, Hawking <Hawking.Zhang@xxxxxxx>; Deucher, Alexander > <Alexander.Deucher@xxxxxxx>; Wang, Yang(Kevin) > <KevinYang.Wang@xxxxxxx>; Quan, Evan <Evan.Quan@xxxxxxx> > Subject: [PATCH] drm/amd/pm: Skip power state allocation > > Power states are not valid for arcturus and aldebaran, no need to > allocate memory. > > Signed-off-by: Lijo Lazar <lijo.lazar@xxxxxxx> > --- > drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 10 ---------- > drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 10 ---------- > 2 files changed, 20 deletions(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c > b/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c > index 05defeee0c87..58bc387fb279 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c > @@ -295,16 +295,6 @@ static int arcturus_allocate_dpm_context(struct > smu_context *smu) > return -ENOMEM; > smu_dpm->dpm_context_size = sizeof(struct > smu_11_0_dpm_context); > > - smu_dpm->dpm_current_power_state = kzalloc(sizeof(struct > smu_power_state), > - GFP_KERNEL); > - if (!smu_dpm->dpm_current_power_state) > - return -ENOMEM; > - > - smu_dpm->dpm_request_power_state = kzalloc(sizeof(struct > smu_power_state), > - GFP_KERNEL); > - if (!smu_dpm->dpm_request_power_state) > - return -ENOMEM; > - > return 0; > } > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c > b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c > index 6e781cee8bb6..0907da022197 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c > @@ -262,16 +262,6 @@ static int aldebaran_allocate_dpm_context(struct > smu_context *smu) > return -ENOMEM; > smu_dpm->dpm_context_size = sizeof(struct > smu_13_0_dpm_context); > > - smu_dpm->dpm_current_power_state = kzalloc(sizeof(struct > smu_power_state), > - GFP_KERNEL); > - if (!smu_dpm->dpm_current_power_state) > - return -ENOMEM; > - > - smu_dpm->dpm_request_power_state = kzalloc(sizeof(struct > smu_power_state), > - GFP_KERNEL); > - if (!smu_dpm->dpm_request_power_state) > - return -ENOMEM; > - > return 0; > } > > -- > 2.25.1
