[Public] > -----Original Message----- > From: Quan, Evan <Evan.Quan@xxxxxxx> > Sent: Friday, December 10, 2021 10:15 AM > To: Liang, Prike <Prike.Liang@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Liang, Prike > <Prike.Liang@xxxxxxx>; Huang, Ray <Ray.Huang@xxxxxxx>; Limonciello, > Mario <Mario.Limonciello@xxxxxxx> > Subject: RE: [PATCH] drm/amd/pm: skip gfx cgpg in the s0ix suspend-resume > > [AMD Official Use Only] > > > > > -----Original Message----- > > From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of > > Prike Liang > > Sent: Thursday, December 9, 2021 9:51 AM > > To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx > > Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Liang, Prike > > <Prike.Liang@xxxxxxx>; Huang, Ray <Ray.Huang@xxxxxxx>; Limonciello, > > Mario <Mario.Limonciello@xxxxxxx> > > Subject: [PATCH] drm/amd/pm: skip gfx cgpg in the s0ix suspend-resume > > > > In the s0ix entry need retain gfx in the gfxoff state,we don't disable > > gfx cgpg in the suspend so there is also needn't enable gfx cgpg in > > the s0ix resume. > > > > Signed-off-by: Prike Liang <Prike.Liang@xxxxxxx> > > --- > > drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > > b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > > index 5839918..185269f 100644 > > --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > > +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > > @@ -1607,7 +1607,8 @@ static int smu_resume(void *handle) > > return ret; > > } > > > > - if (smu->is_apu) > > + /* skip gfx cgpg in the s0ix suspend-resume case*/ > > + if (smu->is_apu && !adev->in_s0ix) > > smu_set_gfx_cgpg(&adev->smu, true); > [Quan, Evan] I was wondering can we move the "!adev->in_s0ix" into the - > >set_gfx_cgpg(for now, only smu_v12_0_set_gfx_cgpg() supported by Renoir) > implementation? > Also, considering this is only supported by Renoir, we may be able to drop > the "smu->is_apu" check. Yes, the set_gfx_cgpg only implemented in the SMU12 series and we can move the S0ix protected in the smu_v12_0_set_gfx_cgpg() and drop the S0ix flag check in the SMU suspend/resume process. Thanks, Prike > > BR > Evan > > > > smu->disable_uclk_switch = 0; > > -- > > 2.7.4
