Re: [PATCH 2/2] drm/amd: move variable to local scope

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 10.12.21 um 17:12 schrieb Limonciello, Mario:
[AMD Official Use Only]

-----Original Message-----
From: Koenig, Christian <Christian.Koenig@xxxxxxx>
Sent: Friday, December 10, 2021 10:07
To: Limonciello, Mario <Mario.Limonciello@xxxxxxx>; amd-
gfx@xxxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH 2/2] drm/amd: move variable to local scope



Am 10.12.21 um 16:54 schrieb Mario Limonciello:
`edp_stream` is only used when backend is enabled on eDP, don't
declare the variable outside that scope.

Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
---
   drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 3 +--
   1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
index 0d6dc329dddb..fb578b311b98 100644
--- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
+++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
@@ -1798,7 +1798,6 @@ void dce110_enable_accelerated_mode(struct dc
*dc, struct dc_state *context)
   	struct dc_stream_state *edp_streams[MAX_NUM_EDP];
   	struct dc_link *edp_link_with_sink = NULL;
   	struct dc_link *edp_link = NULL;
-	struct dc_stream_state *edp_stream = NULL;
   	struct dce_hwseq *hws = dc->hwseq;
   	int edp_with_sink_num;
   	int edp_num;
@@ -1830,7 +1829,7 @@ void dce110_enable_accelerated_mode(struct dc
*dc, struct dc_state *context)
   			if (edp_link->link_enc->funcs->is_dig_enabled &&
   			    edp_link->link_enc->funcs->is_dig_enabled(edp_link-
link_enc) &&
   			    edp_link->link_status.link_active) {
-				edp_stream = edp_streams[0];
+				struct dc_stream_state *edp_stream =
edp_streams[0];
   				can_apply_edp_fast_boot =
!is_edp_ilr_optimization_required(edp_stream->link, &edp_stream->timing);

While you are at it, there should always be an empty line between
declaration and code.
Very well, will fix it.  Can I have a tag with assumption that fix in place, or
should I re-send?

Just fix inline, it's not a major issue anyway.


Running your patches through checkpatch.pl helps spotting such stuff.

Actually checkpatch didn't catch that.

$ ./scripts/checkpatch.pl 0002-drm-amd-move-variable-to-local-scope.patch
total: 0 errors, 0 warnings, 15 lines checked

0002-drm-amd-move-variable-to-local-scope.patch has no obvious style problems and is ready for submission.

Mhm, something is going wrong here. checkpatch.pl is complaining quite badly for that patch:

ERROR: DOS line endings
#169: FILE: drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c:1832:
+^I^I^I^Istruct dc_stream_state *edp_stream = edp_streams[0];^M$

Especially the DOS line ending is not something we can push like this, but could be that the AMD mail servers are messing up things once more.

Christian.


Christian.

   				edp_stream-
apply_edp_fast_boot_optimization = can_apply_edp_fast_boot;
   				if (can_apply_edp_fast_boot)




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux