Re: [PATCH 07/10] drm/amd: append missing includes

[Rodrigo Siqueira Jordao <rjordrigo@xxxxxxx>]

On 2021-12-07 8:25 p.m., Isabella Basso wrote:
> This fixes warnings caused by global functions lacking prototypes:, such as:
>
>   warning: no previous prototype for 'dcn303_hw_sequencer_construct'
>   [-Wmissing-prototypes]
>   12 | void dcn303_hw_sequencer_construct(struct dc *dc)
>      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   ...
>   warning: no previous prototype for ‘amdgpu_has_atpx’
>   [-Wmissing-prototypes]
>   76 | bool amdgpu_has_atpx(void) {
>      |      ^~~~~~~~~~~~~~~
>
> Signed-off-by: Isabella Basso <isabbasso@xxxxxxxxxx>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c                | 1 +
>   .../drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.c    | 2 ++
>   .../gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c | 2 ++
>   drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c     | 2 ++
>   drivers/gpu/drm/amd/display/dc/dcn20/dcn20_init.c               | 2 ++
>   drivers/gpu/drm/amd/display/dc/dcn21/dcn21_init.c               | 2 ++
>   drivers/gpu/drm/amd/display/dc/dcn30/dcn30_init.c               | 2 ++
>   drivers/gpu/drm/amd/display/dc/dcn301/dcn301_init.c             | 2 ++
>   drivers/gpu/drm/amd/display/dc/dcn302/dcn302_init.c             | 2 ++
>   drivers/gpu/drm/amd/display/dc/dcn303/dcn303_init.c             | 2 ++
>   drivers/gpu/drm/amd/display/dc/dcn31/dcn31_init.c               | 2 ++
>   11 files changed, 21 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c
> index c2be6ad62308..d6d986be906a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c
> @@ -11,6 +11,7 @@
>   #include <linux/pci.h>
>   #include <linux/delay.h>
>   
> +#include "amdgpu.h"
>   #include "amd_acpi.h"
>   
>   #define AMDGPU_PX_QUIRK_FORCE_ATPX  (1 << 0)
> diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.c
> index fe18bb9e19aa..06bab24d8e27 100644
> --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.c
> +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.c
> @@ -28,6 +28,8 @@
>   #include "reg_helper.h"
>   #include <linux/delay.h>
>   
> +#include "rv1_clk_mgr_vbios_smu.h"
> +
>   #define MAX_INSTANCE	5
>   #define MAX_SEGMENT		5
>   
> diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c
> index 0c963fc0523f..8161a6ae410d 100644
> --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c
> +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c
> @@ -33,6 +33,8 @@
>   #include "mp/mp_12_0_0_offset.h"
>   #include "mp/mp_12_0_0_sh_mask.h"
>   
> +#include "rn_clk_mgr_vbios_smu.h"
> +
>   #define REG(reg_name) \
>   	(MP0_BASE.instance[0].segment[mm ## reg_name ## _BASE_IDX] + mm ## reg_name)
>   
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> index a6bc3c7673ba..abef132fa016 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> @@ -69,6 +69,8 @@
>   
>   #include "dcn10/dcn10_hw_sequencer.h"
>   
> +#include "dce110_hw_sequencer.h"
> +
>   #define GAMMA_HW_POINTS_NUM 256
>   
>   /*
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_init.c b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_init.c
> index 5cfd4b0afea5..91e4885b743e 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_init.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_init.c
> @@ -27,6 +27,8 @@
>   #include "dcn10/dcn10_hw_sequencer.h"
>   #include "dcn20_hwseq.h"
>   
> +#include "dcn20_init.h"
> +
>   static const struct hw_sequencer_funcs dcn20_funcs = {
>   	.program_gamut_remap = dcn10_program_gamut_remap,
>   	.init_hw = dcn10_init_hw,
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_init.c b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_init.c
> index 54c11ba550ae..b270f0b194dc 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_init.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_init.c
> @@ -28,6 +28,8 @@
>   #include "dcn20/dcn20_hwseq.h"
>   #include "dcn21_hwseq.h"
>   
> +#include "dcn21_init.h"
> +
>   static const struct hw_sequencer_funcs dcn21_funcs = {
>   	.program_gamut_remap = dcn10_program_gamut_remap,
>   	.init_hw = dcn10_init_hw,
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_init.c b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_init.c
> index 93f32a312fee..4926771ddeee 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_init.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_init.c
> @@ -29,6 +29,8 @@
>   #include "dcn21/dcn21_hwseq.h"
>   #include "dcn30_hwseq.h"
>   
> +#include "dcn30_init.h"
> +
>   static const struct hw_sequencer_funcs dcn30_funcs = {
>   	.program_gamut_remap = dcn10_program_gamut_remap,
>   	.init_hw = dcn30_init_hw,
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn301/dcn301_init.c b/drivers/gpu/drm/amd/display/dc/dcn301/dcn301_init.c
> index e85b695f2351..3d42a1a337ec 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn301/dcn301_init.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn301/dcn301_init.c
> @@ -30,6 +30,8 @@
>   #include "dcn30/dcn30_hwseq.h"
>   #include "dcn301_hwseq.h"
>   
> +#include "dcn301_init.h"
> +
>   static const struct hw_sequencer_funcs dcn301_funcs = {
>   	.program_gamut_remap = dcn10_program_gamut_remap,
>   	.init_hw = dcn10_init_hw,
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_init.c b/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_init.c
> index d88b9011c502..eb375f30f5bc 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_init.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_init.c
> @@ -29,6 +29,8 @@
>   
>   #include "dc.h"
>   
> +#include "dcn302_init.h"
> +
>   void dcn302_hw_sequencer_construct(struct dc *dc)
>   {
>   	dcn30_hw_sequencer_construct(dc);
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn303/dcn303_init.c b/drivers/gpu/drm/amd/display/dc/dcn303/dcn303_init.c
> index aa5dbbade2bd..f499f8ab5e47 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn303/dcn303_init.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn303/dcn303_init.c
> @@ -9,6 +9,8 @@
>   #include "dcn30/dcn30_init.h"
>   #include "dc.h"
>   
> +#include "dcn303_init.h"
> +
>   void dcn303_hw_sequencer_construct(struct dc *dc)
>   {
>   	dcn30_hw_sequencer_construct(dc);
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_init.c b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_init.c
> index e175b6cc0125..e5885f62a764 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_init.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_init.c
> @@ -31,6 +31,8 @@
>   #include "dcn301/dcn301_hwseq.h"
>   #include "dcn31/dcn31_hwseq.h"
>   
> +#include "dcn31_init.h"
> +
>   static const struct hw_sequencer_funcs dcn31_funcs = {
>   	.program_gamut_remap = dcn10_program_gamut_remap,
>   	.init_hw = dcn31_init_hw,

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@xxxxxxx>