RE: [PATCH] drm/amdgpu: enable RAS poison flag when GPU is connected to CPU

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[AMD Official Use Only]



>-----Original Message-----
>From: Zhou1, Tao <Tao.Zhou1@xxxxxxx>
>Sent: Wednesday, December 8, 2021 11:50 AM
>To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Zhang, Hawking
><Hawking.Zhang@xxxxxxx>; Ziya, Mohammad zafar
><Mohammadzafar.Ziya@xxxxxxx>
>Cc: Zhou1, Tao <Tao.Zhou1@xxxxxxx>
>Subject: [PATCH] drm/amdgpu: enable RAS poison flag when GPU is
>connected to CPU
>
>The RAS poison mode is enabled by default on the platform.
>
>Signed-off-by: Tao Zhou <tao.zhou1@xxxxxxx>
>---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
>b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
>index a95d200adff9..0003f2c64da8 100644
>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
>@@ -2372,7 +2372,11 @@ int amdgpu_ras_init(struct amdgpu_device *adev)
> 	}
>
> 	/* Init poison supported flag, the default value is false */
>-	if (adev->df.funcs &&
>+	if (adev->gmc.xgmi.connected_to_cpu) {

Why not considering PCIe interface connected device by default? PCIe interface connected device will not see this issue?

>+		/* enabled by default when GPU is connected to CPU */
>+		con->poison_supported = true;
>+	}
>+	else if (adev->df.funcs &&
> 	    adev->df.funcs->query_ras_poison_mode &&
> 	    adev->umc.ras_funcs &&
> 	    adev->umc.ras_funcs->query_ras_poison_mode) {
>--
>2.17.1




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux