RE: [PATCH Review 1/1] drm/amd/pm: print errorno if get ecc info failed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[AMD Official Use Only]

 

OK. If that can help the debugging for RAS development, I’m fine with it.

Reviewed-by: Evan Quan <evan.quan@xxxxxxx>

 

BR

Evan

From: Yang, Stanley <Stanley.Yang@xxxxxxx>
Sent: Monday, December 6, 2021 8:37 PM
To: Quan, Evan <Evan.Quan@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Zhang, Hawking <Hawking.Zhang@xxxxxxx>; Clements, John <John.Clements@xxxxxxx>; Zhou1, Tao <Tao.Zhou1@xxxxxxx>; Li, Candice <Candice.Li@xxxxxxx>; Chai, Thomas <YiPeng.Chai@xxxxxxx>
Subject:
答复: [PATCH Review 1/1] drm/amd/pm: print errorno if get ecc info failed

 

Hi Evan,

 

The error prompts in function smu_cmn_send_smc_msg_with_param do not cover all failed cases since it only prints reg stat SMU_RESP_NONE,

SMU_RESP_BUSY_OTHER or response -EREMOTEIO. I think it is better update reg error stat judgment conditions to print more error msg.

 

Regards,

Stanley

发件人: Quan, Evan <Evan.Quan@xxxxxxx>
日期: 星期一, 2021126 上午9:43
收件人: Yang, Stanley <Stanley.Yang@xxxxxxx>, amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>, Zhang, Hawking <Hawking.Zhang@xxxxxxx>, Clements, John <John.Clements@xxxxxxx>, Zhou1, Tao <Tao.Zhou1@xxxxxxx>, Li, Candice <Candice.Li@xxxxxxx>, Chai, Thomas <YiPeng.Chai@xxxxxxx>
抄送: Yang, Stanley <Stanley.Yang@xxxxxxx>
主题: RE: [PATCH Review 1/1] drm/amd/pm: print errorno if get ecc info failed

[AMD Official Use Only]

Hi Stanley,

There is already error prompts in the smu_cmn_send_smc_msg_with_param() used by the API mentioned below.
Can that cover your use case?

BR
Evan
> -----Original Message-----
> From: Stanley.Yang <Stanley.Yang@xxxxxxx>
> Sent: Sunday, December 5, 2021 6:02 PM
> To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Zhang, Hawking
> <Hawking.Zhang@xxxxxxx>; Clements, John <John.Clements@xxxxxxx>;
> Zhou1, Tao <Tao.Zhou1@xxxxxxx>; Li, Candice <Candice.Li@xxxxxxx>;
> Chai, Thomas <YiPeng.Chai@xxxxxxx>; Quan, Evan <Evan.Quan@xxxxxxx>
> Cc: Yang, Stanley <Stanley.Yang@xxxxxxx>
> Subject: [PATCH Review 1/1] drm/amd/pm: print errorno if get ecc info failed
>
> Signed-off-by: Stanley.Yang <Stanley.Yang@xxxxxxx>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> index 6e781cee8bb6..e0a8224e466f 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> @@ -1815,7 +1815,7 @@ static ssize_t aldebaran_get_ecc_info(struct
> smu_context *smu,
>                               smu_table->ecc_table,
>                               false);
>        if (ret) {
> -             dev_info(smu->adev->dev, "Failed to export SMU ecc
> table!\n");
> +             dev_info(smu->adev->dev, "Failed to export SMU ecc table!
> ret %d.\n", ret);
>                return ret;
>        }
>
> --
> 2.17.1


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux