On 11/25/2021 7:49 AM, Darren Powell wrote:
== Description ==
All the power profile modes use the same strings (or a subset of)
Creating a public array of the strings will allow sharing rather than
duplicating for each chip
First patch only implements change for navi10
Second patch extends the changes to all other implementations of
pp_hwmgr_func->get_power_profile_mode (smu10, smu7, vega10, vega20)
and pptable_funcs->get_power_profile_mode (arcturus, sienna_cichlid, vangogh, renoir)
=== Test System ===
* DESKTOP(AMD FX-8350 + NAVI10(731F/ca), BIOS: F2)
+ ISO(Ubuntu 20.04.3 LTS)
+ Kernel(5.13.0-geabeb4f20a07-fdoagd5f)
=== Patch Summary ===
linux: (git@xxxxxxxxxxxxxxxxxxxxxx:agd5f) origin/amd-staging-drm-next @ 1e7a606dca04
+ 482319edaabb amdgpu/pm: Create shared array of power profile name strings
+ 1e7a606dca04 amdgpu/pm: Modify implmentations of get_power_profile_mode to use amdgpu_pp_profile_name
=== Test ===
LOGFILE=pp_profile_strings.test.log
AMDGPU_PCI_ADDR=`lspci -nn | grep "VGA\|Display" | cut -d " " -f 1`
AMDGPU_HWMON=`ls -la /sys/class/hwmon | grep $AMDGPU_PCI_ADDR | awk '{print $9}'`
HWMON_DIR=/sys/class/hwmon/${AMDGPU_HWMON}
lspci -nn | grep "VGA\|Display" > $LOGFILE
FILES="pp_power_profile_mode "
for f in $FILES
do
echo === $f === >> $LOGFILE
cat $HWMON_DIR/device/$f >> $LOGFILE
done
cat $LOGFILE
Darren Powell (2):
amdgpu/pm: Create shared array of power profile name strings
amdgpu/pm: Modify implmentations of get_power_profile_mode to use
amdgpu_pp_profile_name
Series is -
Reviewed-by: Lijo Lazar <lijo.lazar@xxxxxxx>
Thanks,
Lijo
drivers/gpu/drm/amd/include/kgd_pp_interface.h | 4 ++++
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 10 ++++++++++
.../gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c | 9 +--------
.../gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 14 +++-----------
.../gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c | 12 +++---------
.../gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.c | 10 +---------
drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 10 +---------
drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 10 +---------
.../drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 10 +---------
drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 10 +---------
drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c | 10 +---------
11 files changed, 27 insertions(+), 82 deletions(-)
base-commit: eabeb4f20a0786188fba07a2dd1b0a614c4e15f6
