[AMD Official Use Only]
Agree.
Patch applied. Thanks for your review
-Leo
-----Original Message-----
From: Alex Deucher <alexdeucher@xxxxxxxxx>
Sent: Thursday, November 18, 2021 12:02 PM
To: Ma, Leo <Hanghong.Ma@xxxxxxx>
Cc: Kazlauskas, Nicholas <Nicholas.Kazlauskas@xxxxxxx>; amd-gfx list <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Choi, Nicholas <Nicholas.Choi@xxxxxxx>; Wentland, Harry <Harry.Wentland@xxxxxxx>
Subject: Re: [PATCH] drm/amd/display: Drop config guard for DC_LOG_DP2
On Thu, Nov 18, 2021 at 11:53 AM Leo (Hanghong) Ma <hanghong.ma@xxxxxxx> wrote:
>
> [Why & How]
> It doesn't make sense to guard DC_LOG_DP2 by CONFIG_DRM_AMD_DCN, and
> this also caused build failure for allmodconfig; So drop the guard to
> fix the compile failure;
>
> Signed-off-by: Leo (Hanghong) Ma <hanghong.ma@xxxxxxx>
Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>
At some point we may want to rework what the DC_LOG stuff maps too (e.g., use dev_debug or the newer drm interfaces).
Alex
> ---
> drivers/gpu/drm/amd/display/include/logger_types.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/include/logger_types.h
> b/drivers/gpu/drm/amd/display/include/logger_types.h
> index 370fad883e33..f093b49c5e6e 100644
> --- a/drivers/gpu/drm/amd/display/include/logger_types.h
> +++ b/drivers/gpu/drm/amd/display/include/logger_types.h
> @@ -72,9 +72,7 @@
> #define DC_LOG_DSC(...) DRM_DEBUG_KMS(__VA_ARGS__) #define
> DC_LOG_SMU(...) pr_debug("[SMU_MSG]:"__VA_ARGS__) #define
> DC_LOG_DWB(...) DRM_DEBUG_KMS(__VA_ARGS__) -#if
> defined(CONFIG_DRM_AMD_DC_DCN) #define DC_LOG_DP2(...)
> DRM_DEBUG_KMS(__VA_ARGS__) -#endif
>
> struct dal_logger;
>
> @@ -126,9 +124,7 @@ enum dc_log_type {
> LOG_MAX_HW_POINTS,
> LOG_ALL_TF_CHANNELS,
> LOG_SAMPLE_1DLUT,
> -#if defined(CONFIG_DRM_AMD_DC_DCN)
> LOG_DP2,
> -#endif
> LOG_SECTION_TOTAL_COUNT
> };
>
> --
> 2.17.1
>
