Re: [PATCH] drm/amd/display: fix cond_no_effect.cocci warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Applied.  Thanks!

Alex

On Fri, Nov 12, 2021 at 1:17 AM <cgel.zte@xxxxxxxxx> wrote:
>
> From: Ye Guojin <ye.guojin@xxxxxxxxxx>
>
> This was found by coccicheck:
> ./drivers/gpu/drm/amd/display/dc/core/dc_resource.c, 2516, 7-9, WARNING
> possible condition with no effect (if == else)
>
> hdmi_info.bits.YQ0_YQ1 is always YYC_QUANTIZATION_LIMITED_RANGE.
>
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Ye Guojin <ye.guojin@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
> index fabe1b83bd4f..564163a85d2c 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
> @@ -2509,17 +2509,7 @@ static void set_avi_info_frame(
>
>         /* TODO : We should handle YCC quantization */
>         /* but we do not have matrix calculation */
> -       if (stream->qy_bit == 1) {
> -               if (color_space == COLOR_SPACE_SRGB ||
> -                       color_space == COLOR_SPACE_2020_RGB_FULLRANGE)
> -                       hdmi_info.bits.YQ0_YQ1 = YYC_QUANTIZATION_LIMITED_RANGE;
> -               else if (color_space == COLOR_SPACE_SRGB_LIMITED ||
> -                                       color_space == COLOR_SPACE_2020_RGB_LIMITEDRANGE)
> -                       hdmi_info.bits.YQ0_YQ1 = YYC_QUANTIZATION_LIMITED_RANGE;
> -               else
> -                       hdmi_info.bits.YQ0_YQ1 = YYC_QUANTIZATION_LIMITED_RANGE;
> -       } else
> -               hdmi_info.bits.YQ0_YQ1 = YYC_QUANTIZATION_LIMITED_RANGE;
> +       hdmi_info.bits.YQ0_YQ1 = YYC_QUANTIZATION_LIMITED_RANGE;
>
>         ///VIC
>         format = stream->timing.timing_3d_format;
> --
> 2.25.1
>



[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux