Re: [PATCH] drm/amdgpu/pm: Don't show pp_power_profile_mode for YC and later APUs

["Lazar, Lijo" <Lijo.Lazar@xxxxxxx>]

There are two subsystems - powerplay and swsmu. The subsystem implementation details are hidden from amdgpu_pm funcs. I thought Alex is talking about that.

Thanks,
Lijo

---

From: Limonciello, Mario <Mario.Limonciello@xxxxxxx>
Sent: Monday, November 1, 2021 8:16:27 AM
To: Lazar, Lijo <Lijo.Lazar@xxxxxxx>; Alex Deucher <alexdeucher@xxxxxxxxx>
Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>
Subject: RE: [PATCH] drm/amdgpu/pm: Don't show pp_power_profile_mode for YC and later APUs

 

[Public]

 

smu_get_power_profile_mode actually calls smu->ppt_funcs->get_power_profile_mode

 

So shouldn’t it be sufficient to do this?

 

        } else if (DEVICE_ATTR_IS(pp_power_profile_mode)) {

                if (!adev->smu.ppt_funcs->get_power_profile_mode)

                        *states = ATTR_STATE_UNSUPPORTED;

        }

 

 

From: Lazar, Lijo <Lijo.Lazar@xxxxxxx>
Sent: Saturday, October 30, 2021 10:06
To: Alex Deucher <alexdeucher@xxxxxxxxx>
Cc: Limonciello, Mario <Mario.Limonciello@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Deucher, Alexander <Alexander.Deucher@xxxxxxx>
Subject: Re: [PATCH] drm/amdgpu/pm: Don't show pp_power_profile_mode for YC and later APUs

 

[Public]

 

For swsmu, we could add a helper macro like smu_is_supported(x) that checks if ppt func is not NULL.

 

Thanks,
Lijo