On Thu, 2021-10-21 at 13:00 +0300, Jani Nikula wrote: > On Wed, 20 Oct 2021, Khaled Almahallawy <khaled.almahallawy@xxxxxxxxx > > wrote: > > This series updates DPCD 248h register name and PHY test patterns > > names to follow DP 2.0 Specs. > > Also updates the DP PHY CTS codes of the affected drivers (i915, > > amd, msm) > > No functional changes expected. > > > > Reference: “DPCD 248h/10Bh/10Ch/10Dh/10Eh Name/Description > > Consistency” > > https://groups.vesa.org/wg/AllMem/documentComment/2738 > > You can't do renames like this piece by piece. Every commit must > build. Noted, I apologize for messing that up. I will send v2 to make sure all renames of DP_PHY_TEST_PATTERN done in one patch with the other changes you requested. Thank you for your review Khaled > > Incidentally, this is one of the reasons we often don't bother with > renames to follow spec changes, but rather stick to the original > names. > > However, in this case you could switch all drivers to the different > test > pattern macros piece by piece, as they're already there. > > > BR, > Jani. > > > > Khaled Almahallawy (4): > > drm/dp: Rename DPCD 248h according to DP 2.0 specs > > drm/i915/dp: Use DP 2.0 LINK_QUAL_PATTERN_* Phy test pattern > > definitions > > drm/amd/dc: Use DPCD 248h DP 2.0 new name > > drm/msm/dp: Use DPCD 248h DP 2.0 new names/definitions > > > > drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +- > > drivers/gpu/drm/drm_dp_helper.c | 6 +++--- > > drivers/gpu/drm/i915/display/intel_dp.c | 12 ++++++------ > > drivers/gpu/drm/msm/dp/dp_catalog.c | 12 ++++++------ > > drivers/gpu/drm/msm/dp/dp_ctrl.c | 12 ++++++------ > > drivers/gpu/drm/msm/dp/dp_link.c | 16 ++++++++-- > > ------ > > include/drm/drm_dp_helper.h | 13 +++--------- > > - > > 7 files changed, 33 insertions(+), 40 deletions(-)
