On Mon, Oct 18, 2021 at 11:22 PM Aaron Liu <aaron.liu@xxxxxxx> wrote: > > B0 internal rev_id is 0x01, B1 internal rev_id is 0x02. > The external rev_id for B0 and B1 is 0x20. > The original expression is not suitable for B1. Are you sure about this? We'll be losing the difference between B0 and B1. I think 0x19 is correct. What will give us 0x1a for B0 and 0x1b for B1. That aligns with what the display code has as well. Alex > > Signed-off-by: Aaron Liu <aaron.liu@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/nv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c > index 898e688be63c..5166a1573e7e 100644 > --- a/drivers/gpu/drm/amd/amdgpu/nv.c > +++ b/drivers/gpu/drm/amd/amdgpu/nv.c > @@ -1248,7 +1248,7 @@ static int nv_common_early_init(void *handle) > AMD_PG_SUPPORT_VCN_DPG | > AMD_PG_SUPPORT_JPEG; > if (adev->pdev->device == 0x1681) > - adev->external_rev_id = adev->rev_id + 0x19; > + adev->external_rev_id = 0x20; > else > adev->external_rev_id = adev->rev_id + 0x01; > break; > -- > 2.25.1 >
