Re: [PATCH] drm/amdkfd: Fix an inappropriate error handling in allloc memory of gpu

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



LGTM as we create a gem object 1st and retrieve amdgpu_bo from the gem object.


Acked-by: Nirmoy Das <nirmoy.das@xxxxxxx>

On 10/13/2021 9:28 AM, Lang Yu wrote:
We should unreference a gem object instead of an amdgpu bo here.

Fixes: 5ae0283e831a ("drm/amdgpu: Add userptr support for KFD")

Signed-off-by: Lang Yu <lang.yu@xxxxxxx>
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
index 054c1a224def..cdf46bd0d8d5 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
@@ -1503,7 +1503,7 @@ int amdgpu_amdkfd_gpuvm_alloc_memory_of_gpu(
  	remove_kgd_mem_from_kfd_bo_list(*mem, avm->process_info);
  	drm_vma_node_revoke(&gobj->vma_node, drm_priv);
  err_node_allow:
-	amdgpu_bo_unref(&bo);
+	drm_gem_object_put(gobj);
  	/* Don't unreserve system mem limit twice */
  	goto err_reserve_limit;
  err_bo_create:



[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux