[Public] >-----Original Message----- >From: Paul Menzel <pmenzel@xxxxxxxxxxxxx> >Sent: Tuesday, October 12, 2021 4:51 PM >To: Yu, Lang <Lang.Yu@xxxxxxx> >Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Huang, Ray ><Ray.Huang@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx >Subject: Re: [PATCH] drm/amdgpu: enable display for cyan skillfish > >Dear Lang, > > >Am 12.10.21 um 08:16 schrieb Lang Yu: >> Display support for cyan skillfish is ready now. > >What is the last commit making it “ready”? This one, commit 4ac93fa0ec12a887b40b81d9b8b7fcd1033f48d5 drm/amd/display: add cyan_skillfish display support Actually, it is fine before switching to amdgpu_discovery_set_ip_blocks. During developing amdgpu_discovery_set_ip_blocks, it is not ready. So skip to enable it. >> Enable it! > >How did you test the patch? I compiled amdgpu driver with this patch and loaded it on ubuntu 20.04. The display worked well. Otherwise the display won't work. Regards, Lang >> Signed-off-by: Lang Yu <lang.yu@xxxxxxx> >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c >> b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c >> index 2bebd2ce6474..4228c7964175 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c >> @@ -736,6 +736,7 @@ static int >amdgpu_discovery_set_display_ip_blocks(struct amdgpu_device *adev) >> case IP_VERSION(1, 0, 1): >> case IP_VERSION(2, 0, 2): >> case IP_VERSION(2, 0, 0): >> + case IP_VERSION(2, 0, 3): > >The numbers are not ordered. Could you please put a patch before this one, fixing >the ordering? > >> case IP_VERSION(2, 1, 0): >> case IP_VERSION(3, 0, 0): >> case IP_VERSION(3, 0, 2): >> @@ -745,8 +746,6 @@ static int >amdgpu_discovery_set_display_ip_blocks(struct amdgpu_device *adev) >> case IP_VERSION(3, 1, 3): >> amdgpu_device_ip_block_add(adev, &dm_ip_block); >> break; >> - case IP_VERSION(2, 0, 3): >> - break; >> default: >> return -EINVAL; >> } >> > > >Kind regards, > >Paul
