Re: [PATCH 02/02 v2] drm/amd/display: add cyan_skillfish display support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 27, 2021 at 5:16 PM Liu, Zhan <Zhan.Liu@xxxxxxx> wrote:
>
> [Public]
>
> [Why]
> add display related cyan_skillfish files in.
>
> makefile controlled by CONFIG_DRM_AMD_DC_DCN201 flag.
>
> Signed-off-by: Charlene Liu <charlene.liu@xxxxxxx>
> Signed-off-by: Zhan Liu <zhan.liu@xxxxxxx>
> Reviewed-by: Charlene Liu <charlene.liu@xxxxxxx>
> Acked-by: Jun Lei <jun.lei@xxxxxxx>
> ---
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 1d6cc93..0c669e4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1968,6 +1968,9 @@
>         case CHIP_VANGOGH:
>                 chip_name = "vangogh";
>                 break;
> +       case CHIP_CYAN_SKILLFISH:
> +               chip_name = "cyan_skillfish";
> +               break;
>         case CHIP_YELLOW_CARP:
>                 chip_name = "yellow_carp";
>                 break;

Sorry I missed this before.  This change is unnecessary.  there is no
gpu_info firmware for cyan skillfish.  Please drop this hunk.  With
that fixed:
Acked-by: Alex Deucher <alexander.deucher@xxxxxxx>

Alex



[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux