[AMD Official Use Only] > -----Original Message----- > From: Borislav Petkov <bp@xxxxxxxxx> > Sent: Thursday, September 23, 2021 10:37 AM > To: Ghannam, Yazen <Yazen.Ghannam@xxxxxxx> > Cc: Joshi, Mukul <Mukul.Joshi@xxxxxxx>; linux-edac@xxxxxxxxxxxxxxx; > x86@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; mingo@xxxxxxxxxx; > mchehab@xxxxxxxxxx; amd-gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCHv3 2/2] drm/amdgpu: Register MCE notifier for Aldebaran > RAS > > [CAUTION: External Email] > > On Thu, Sep 23, 2021 at 02:29:07PM +0000, Yazen Ghannam wrote: > > > + /* > > > + * If the error was generated in UMC_V2, which belongs to GPU UMCs, > > > + * and error occurred in DramECC (Extended error code = 0) then only > > > + * process the error, else bail out. > > > + */ > > > + if (!m || !((smca_get_bank_type(m->bank) == SMCA_UMC_V2) && > > > + (XEC(m->status, 0x1f) == 0x0))) > > > > The MCA_STATUS[ErrorCodeExt] field is bits [21:16], so the mask should > > be 0x3f. > > > > > + return NOTIFY_DONE; > > > + > > > + /* > > > + * If it is correctable error, return. > > > + */ > > > + if (mce_is_correctable(m)) > > > + return NOTIFY_OK; > > > > Shouldn't this be "NOTIFY_DONE" if "don't care" about this error? > > I think the logic here is to stop calling any further consumers on the notify chain > because this is a GPU correctable error and they can't do anything about it > anyway, right? That's correct. Regards, Mukul > > Or am I misreading it? > > -- > Regards/Gruss, > Boris. > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpeople. > kernel.org%2Ftglx%2Fnotes-about- > netiquette&data=04%7C01%7Cmukul.joshi%40amd.com%7C1493bcdae62 > 8466d5b8408d97e9fa6f0%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0 > %7C637680046455034969%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw > MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata > =uqbjJslUPJabZonJc6m9Ub3C5IkZDPdqwr6MI0oLPcc%3D&reserved=0
