Re: [PATCH 1/2] drm/amdgpu: Increase direct IB pool size

[Christian König <ckoenig.leichtzumerken@xxxxxxxxx>]

    Ok, good to know. That's probably the reason why we didn't push that
    stuff into the IB in the first place.
    
    And yes, using fixed 256kiB sounds like a plan to me then, but
    please also double check the AMDGPU_IB_POOL_SIZE define.
    
    I also won't mind if you just open code the two initialization since
    there probably will never be any more than that. 
    
    Thanks,
    Christian.

Am 09.09.21 um 09:57 schrieb Pan, Xinhui:

[AMD Official Use Only]

yep, vcn need 128kb extra memory.  I will make the pool size constant as 256kb.

---

From: Koenig, Christian <Christian.Koenig@xxxxxxx>
Sent: Thursday, September 9, 2021 3:14:15 PM
To: Pan, Xinhui <Xinhui.Pan@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>
Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>
Subject: Re: [PATCH 1/2] drm/amdgpu: Increase direct IB pool size

 

Am 09.09.21 um 07:54 schrieb Pan, Xinhui:
> [AMD Official Use Only]
>
> Direct IB pool is used for vce/uvd/vcn IB extra msg too. Increase its
> size to 64 pages.

Do you really run into issues with that? 64 pages are 256kiB on x86 and
the extra msg are maybe 2kiB.

Additional to that we should probably make this a constant independent
of the CPU page size.

Christian.

>
> Signed-off-by: xinhui pan <xinhui.pan@xxxxxxx>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
> index c076a6b9a5a2..cd2c7073fdd9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
> @@ -308,7 +308,7 @@ int amdgpu_ib_pool_init(struct amdgpu_device *adev)
>
>          for (i = 0; i < AMDGPU_IB_POOL_MAX; i++) {
>                  if (i == AMDGPU_IB_POOL_DIRECT)
> -                       size = PAGE_SIZE * 6;
> +                       size = PAGE_SIZE * 64;
>                  else
>                          size = AMDGPU_IB_POOL_SIZE;
>
> --
> 2.25.1
>